feat(override-rules): add certifications to override rules - #3335
feat(override-rules): add certifications to override rules#3335aussierk wants to merge 4 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughWalkthroughOverride rules now support country-specific movie and TV certifications. Certifications are stored in the database, accepted by the API, matched during request processing, and managed through the settings interface. ChangesCertification-based override rules
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change adds certification-based override-rule conditions for routing requested content. The reported validation covers persistence, matching and non-matching requests, migrations, and related rule combinations; no actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant User
participant OverrideRuleModal
participant OverrideRuleRoute
participant OverrideRule
participant MediaRequest
User->>OverrideRuleModal: select certifications
OverrideRuleModal->>OverrideRuleRoute: submit certification condition
OverrideRuleRoute->>OverrideRule: create or update rule
MediaRequest->>OverrideRule: load override rules
MediaRequest->>MediaRequest: compare and prioritize certifications
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/components/Selector/CertificationSelector.tsx (1)
57-71: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winExtract the duplicated country-name-resolution logic into a shared utility. Both sites derive a localized country name (with subdivision support) from an ISO code using the same
split('-')+intl.formatDisplayName+ try/catch fallback pattern.
src/components/Selector/CertificationSelector.tsx#L57-L71: keep this as the canonical implementation, but extract it into a shared exported helper (for examplesrc/utils/certificationCountryName.ts) that acceptsintland the country code.src/components/Settings/OverrideRule/OverrideRuleTiles.tsx#L227-L256: replace the inline try/catch block with a call to the shared helper instead of re-implementing the same logic.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Selector/CertificationSelector.tsx` around lines 57 - 71, Extract the getCountryName logic from src/components/Selector/CertificationSelector.tsx lines 57-71 into a shared exported helper that accepts intl and the country code, preserving subdivision formatting and try/catch fallback behavior; update CertificationSelector.tsx to use it. In src/components/Settings/OverrideRule/OverrideRuleTiles.tsx lines 227-256, remove the duplicated inline resolution logic and call the shared helper instead.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/Settings/OverrideRule/OverrideRuleModal.tsx`:
- Around line 421-442: Update the service select onChange handler in
OverrideRuleModal to reset certification to null whenever the selected service
switches between Radarr, Sonarr, or no service, alongside the existing
radarrServiceId and sonarrServiceId updates. Preserve the current validation
reset behavior for the no-service branch.
In `@src/components/Settings/OverrideRule/OverrideRuleTiles.tsx`:
- Around line 227-256: Add a stable, unique key to each certification item span
returned by the map callback in the certification rendering within
OverrideRuleTiles. Use the entry value or another combination that uniquely
identifies each certification, while leaving the displayed country and
certification text unchanged.
---
Nitpick comments:
In `@src/components/Selector/CertificationSelector.tsx`:
- Around line 57-71: Extract the getCountryName logic from
src/components/Selector/CertificationSelector.tsx lines 57-71 into a shared
exported helper that accepts intl and the country code, preserving subdivision
formatting and try/catch fallback behavior; update CertificationSelector.tsx to
use it. In src/components/Settings/OverrideRule/OverrideRuleTiles.tsx lines
227-256, remove the duplicated inline resolution logic and call the shared
helper instead.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0f234804-85f7-4560-bdff-c1ce09248665
📒 Files selected for processing (10)
server/entity/MediaRequest.tsserver/entity/OverrideRule.tsserver/migration/postgres/1785245866761-AddCertificationToOverrideRules.tsserver/migration/sqlite/1785245659122-AddCertificationToOverrideRules.tsserver/routes/overrideRule.tssrc/components/Selector/CertificationSelector.tsxsrc/components/Selector/index.tsxsrc/components/Settings/OverrideRule/OverrideRuleModal.tsxsrc/components/Settings/OverrideRule/OverrideRuleTiles.tsxsrc/i18n/locale/en.json
2dea89d to
a1256b7
Compare
|
Going to address these fixes and then figure out where I went wrong with the PR template. |
|
I have addressed the issues flagged by Code Rabbit to tighten up the code. I have also found the additional space that was causing the template validation to break. I am happy to continue reworking the override rules to address some of the other issues and to fix the rule ranking system in separate PRs. |
dc358dd to
0103458
Compare
… rules Adds a certification condition to override rules, so admins can target requests by content rating(e.g. US:PG-13) in addition to genre, language, and keywords. Country is pinned per entry since TMDB certification codes aren't comparable across regions. This change only implements the backend portion of the change and involves a database migration to add the certification field.] feature seerr-team#301
Adds a flat multi-select certification picker to the override rule create/edit modal and its list-view tiles, wired to the backend certification condition already in place. Modified a previously unused CertificationSelector from the repo to match values and method expected in the override rules certification condition. feature seerr-team#301
… meaning display in ui modified the ui for certification option in override rules to sort by country then maturity rating. Moved meaning from display in-line to tool tip for better scrollability. feature seerr-team#301
…d reset on service change Adressed codeRabbit findings by adding a key to the overrideruletiles for certification and reset the certification value if the service was changed while in the overriderule modal. feature seerr-team#301
0103458 to
e3ea73c
Compare
1 participant
Description
I added the ability to implement an override-rule condition for the certification/parental-rating of the content being requested. It is integrated to the existing system for override-rules allowing users to set conditions to modify the root directory, the tags, and/or the quality profile of the content that is requested.To achieve this, I added the rule that required content to match any of the selected certification values in the rule to meet the condition. This required that the media be parsed for release dates, iso_3166_1 and the certification or content_rating as part of the existing tmdbMedia call that is made during a request.
I needed to add a certification value to the override rules table in the database so that the condition could be registered alongside the other override rule conditions and I then added the certification condition to the UI so that users could set the condition as part of the existing menu. I refactored an existing unused UI CertificationSelector element to match the required values and interface used for the override rule.
It facilitates the sorting of content by rating to allow the sorting of kids content and adult or teen content into different libraries more easily without needing two radarr or sonarr instances.How Has This Been Tested?
I ran pnpm test (133 passing), pnpm typecheck, pnpm lint and pnpm build all pass.
I tested against a local seer instance connected to radarr and sonarr. I created two local users, one admin, and one regular user without privileges.database
Screenshots / Logs (if applicable)
Checklist:
I have read and followed the contribution guidelines.
Disclosed any use of AI (see our policy)
I have updated the documentation accordingly.
All new and existing tests passed.
Successful build
pnpm buildTranslation keys
pnpm i18n:extractDatabase migration (if required)
AI Disclosure: I used AI assistance for code review and small amount of debugging but all code was written and designed by myself.
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Improvements