feat(notifications): add support for ntfy.sh tags - #3350
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughNtfy settings now support optional comma-separated tags. The settings form persists and tests the value, the API schema exposes it, and notification payloads include trimmed non-empty tags. ChangesNtfy tag configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds ntfy.sh tag support without any identified merge-blocking risk at the current head; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant NotificationsNtfy
participant SettingsAPI
participant NtfyAgent
NotificationsNtfy->>SettingsAPI: Save or test tags
SettingsAPI->>NtfyAgent: Provide Ntfy settings
NtfyAgent->>NtfyAgent: Parse and filter tags
NtfyAgent-->>SettingsAPI: Build payload with non-empty tags
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: 0xsysr3ll <31414959+0xSysR3ll@users.noreply.github.com>
Description
This adds support for ntfy.sh tags system. This will make subscribers of mass topics differentiate app types. As an example say you have a media topic on which all *arr's are publishing messages and you'd like to add Seerr as well below the tag Seerr (and optional emoji). See the screenshot for how this looks in app.
AI Disclosure: I used ChatGPT to get my bearings in the codebase and give me a list of stuff to change and do to contribute (stuff like filenames:line number, what to put into the pr and commit title etc).
How Has This Been Tested?
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit
New Features
eyesoreyes,warning.Documentation