refactor: extract duplicated CSV fetch logic into a single reusable function in useCSVData#103
Open
Harshit-Mishra2212 wants to merge 1 commit into
Conversation
|
@Harshit-Mishra2212 is attempting to deploy a commit to the SEETA's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
In
useCSVData.ts, the CSV fetch and parse logic was written out twice in full - once inside theuseEffectasfetchCSV, andagain inside
mutate. Both functions made the same fetch call to the same URL, used the same PapaParse config, set the same state variables, and logged the same console messages. They were identical in every way.This meant any change to fetch behaviour, parse config, error handling, or logging had to be applied in two places. The two copies had already drifted slightly in their console.log messages ('Fetching CSV data...' vs 'Manually refreshing CSV data...') even
though they do the same thing.
No related issue.
✅ Changes
Refactor
Extracted fetch and parse logic into a single
loadCSVfunction wrapped inuseCallbackuseEffectnow callsloadCSVdirectly instead of defining its own copymutateis now justloadCSV- no separate implementationExtracted the CSV URL into a
CSV_URLconstant so it is defined once at the top of the fileAdded
useCallbackimport alongside existing React imports📷 Screenshots / Demo
Not applicable - internal hook refactor with no UI changes.
Checklist