fix: remove unused imports, dead code block, and add fetch error guard in DeveloperEngagementDashboard#83
Open
Harshit-Mishra2212 wants to merge 1 commit into
Conversation
…d in DeveloperEngagementDashboard
|
@Harshit-Mishra2212 is attempting to deploy a commit to the SEETA's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While going through
DeveloperEngagementDashboard.tsx, found three issues in the same file — unused imports that bloat the client bundle, a guard block that can never execute, and a fetch call that doesn't checkresponse.okbefore parsing the response as data.Fixes #54
Changes
Papa,ParseResult,ParseConfig,ParseError, andParserimports frompapaparse— the CSV loading was switched tofetch + response.json()at some point but the import was never cleaned upif (!processedData && isLoading)guard block — the block above it already returns whenprocessedDatais falsy, so this block can never run. Also removed the now-unusedLoadingSpinnerimportresponse.okcheck inloadCSVDatabefore callingresponse.json()— without this, a 500 or 404 from/api/cohortsilently gets treated as valid engagement data and passed through the entire processing pipelineScreenshots / Demo
N/A - no visual change on the happy path. The fetch guard surfaces actual server errors instead of silently corrupting the data pipeline.
Additional Notes
All three changes are in
src/components/dashboard/DeveloperEngagementDashboard.tsxonly. No other files touched. The unreachable block was likely left over from an earlier refactor where the loading/error handling sequence was reorganised but the old guard wasn't removed.Checklist