Skip to content

fix: correct issue metrics and engagement trend calculations #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nehayadav827 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct issue metrics and engagement trend calculations #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions src/lib/data-processing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,10 +468,25 @@ function processRawIssueMetrics(entries: EngagementData[]): IssueMetrics[] {
return sum + (value === '4+' ? 4 : parseInt(value || '0'));
}, 0);

const hasGitHubLink = weekEntries.some(entry => entry['Issue Link 1']);
const closedIssues = hasGitHubLink
? weekEntries.filter(entry => entry['Issue Link 1']?.includes('closed')).length
: Math.round(totalIssues * 0.7);
// GitHub issue URLs do not indicate state; closed issues use the same URL.
// Treat issues as closed only when contributors explicitly describe them that way.
const closedIssues = weekEntries.filter(entry => {
const desc1 = getStringValue(entry['Issue Description 1']).toLowerCase();
const desc2 = getStringValue(entry['Issue Description 2']).toLowerCase();
const desc3 = getStringValue(entry['Issue Description 3']).toLowerCase();

return (
desc1.includes('closed') ||
desc1.includes('resolved') ||
desc1.includes('merged') ||
desc2.includes('closed') ||
desc2.includes('resolved') ||
desc2.includes('merged') ||
desc3.includes('closed') ||
desc3.includes('resolved') ||
desc3.includes('merged')
);
}).length;

return {
week: week.replace(/\(.*?\)/, '').trim(),
Expand Down Expand Up @@ -718,13 +733,24 @@ function calculateEngagementTrends(csvData: any[]): EngagementTrend[] {
uniqueNames: new Set(entries.map(e => e.Name))
});

const highEngagement = entries.filter(e =>
e['Engagement Participation ']?.trim().startsWith('3')
).length;

const mediumEngagement = entries.filter(e =>
e['Engagement Participation ']?.trim().startsWith('2')
).length;

const lowEngagement = entries.filter(e =>
e['Engagement Participation ']?.trim().startsWith('1')
).length;

return {
week: `Week ${parseWeekNumber(week)}`,
total: activeContributors,
// Add zero values for backward compatibility
'High Engagement': 0,
'Medium Engagement': 0,
'Low Engagement': 0
'High Engagement': highEngagement,
'Medium Engagement': mediumEngagement,
'Low Engagement': lowEngagement
};
});
}
Expand Down