fix: correct contributor growth calculations#96
Open
nehayadav827 wants to merge 1 commit into
Open
Conversation
|
@nehayadav827 is attempting to deploy a commit to the SEETA's projects Team on Vercel. A member of the Team first needs to authorize it. |
Open
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a data correctness issue in
src/lib/data-processing.tswherecontributorGrowthalways returned a single hardcoded entry instead of a real per-week contributor growth breakdown.This directly relates to the Builder Intelligence analytics layer described in Issue #68.
Problem
Previously,
processData()returned:This caused multiple analytics issues:
returningContributorsalways remained0newContributorsincorrectly used the all-time contributor countFix
Added
calculateContributorGrowth()to:processData()now uses:Changes
calculateContributorGrowth()src/lib/data-processing.tsValidation
A standalone local validation script was used during development to verify:
Validation result:
Validation Output
Also ran:
No formatting or whitespace issues were reported.
Additional Notes
Current repository checks still contain unrelated existing blockers:
npx tsc --noEmit --pretty falsefails on existing test typing/fixture issues insrc/lib/__tests__/utils.test.tsnpm test -- --runInBand src/lib/__tests__/utils.test.tsfails on an existing expectation mismatch unrelated to this changeNo breaking changes introduced.
Checklist
Relates to #68