Skip to content

Update Firebase SDK to v12.1.0 and dependencies #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+49 −37
Open

Update Firebase SDK to v12.1.0 and dependencies #32

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cdbd7e
Update Firebase SDK to v12.1.0 and dependencies
rickpasveer Aug 6, 2025
70674da
Remove deeplink settings
rickpasveer Aug 7, 2025
f9ddf04
Updated minimum platform versions to match firebase sdk
rickpasveer Aug 7, 2025
91234f0
Lower swift tools for package.swift
rickpasveer Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 43 additions & 25 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
// swift-tools-version:5.3
// swift-tools-version:6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary?

Copy link

@lhunath lhunath Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that 6.0 has made it to https://github.com/swiftlang/swift-package-manager/tree/main/Documentation/ReleaseNotes yet. Not sure why.

Presumably this is just a "bump to latest", I don't see any change that should benefit from or necessitate it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've lowered the package swift tools requirement to 5.9 to match the version defined in https://github.com/segmentio/analytics-swift.git

// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
name: "SegmentFirebase",
platforms: [
.macOS("10.15"),
.iOS("13.0"),
.tvOS("13.0"),
.watchOS("7.1")
.macOS(.v10_15),
.iOS(.v15),
.tvOS(.v15),
.watchOS(.v7)
],
products: [
// Products define the executables and libraries a package produces, and make them visible to other packages.
Expand All @@ -28,7 +28,7 @@ let package = Package(
.package(
name: "Firebase",
url: "https://github.com/firebase/firebase-ios-sdk",
from: "11.1.0"
from: "12.0.0"
)
],
targets: [
Expand Down
6 changes: 0 additions & 6 deletions Sources/SegmentFirebase/FirebaseDestination.swift
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this stuff removed?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove deeplink setup due to https://firebase.google.com/support/dynamic-links-faq

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks. Makes sense.

Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,6 @@ open class FirebaseDestination: DestinationPlugin {
// we've already set up this singleton SDK, can't do it again, so skip.
guard type == .initial else { return }

guard let firebaseSettings: FirebaseSettings = settings.integrationSettings(forPlugin: self) else { return }
if let deepLinkURLScheme = firebaseSettings.deepLinkURLScheme {
FirebaseOptions.defaultOptions()?.deepLinkURLScheme = deepLinkURLScheme
analytics?.log(message: "Added deepLinkURLScheme: \(deepLinkURLScheme)")
}

// First check if firebase has been set up from a previous settings call
if (FirebaseApp.app() != nil) {
analytics?.log(message: "Firebase already configured, skipping")
Expand Down