Skip to content

Fix issue where user-supplied enrichments were lost during the startup phase #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 23, 2025

Conversation

wenxi-zeng
Copy link
Contributor

  • made the enrichment closure a property of event so it is not lost during startup queue replay

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 74.28571% with 18 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (b958b36) to head (db6e669).
Report is 6 commits behind head on main.

Current head db6e669 differs from pull request most recent head f38a847

Please upload reports for the commit f38a847 to get more accurate results.

Files with missing lines Patch % Lines
...om/segment/analytics/kotlin/core/AnalyticsTests.kt 71.66% 0 Missing and 17 partials ⚠️
...com/segment/analytics/kotlin/core/utils/Plugins.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #260      +/-   ##
============================================
+ Coverage     78.13%   79.82%   +1.69%     
+ Complexity      592      575      -17     
============================================
  Files            80       77       -3     
  Lines          7275     6918     -357     
  Branches        922     1069     +147     
============================================
- Hits           5684     5522     -162     
+ Misses          861      492     -369     
- Partials        730      904     +174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wenxi-zeng wenxi-zeng merged commit 43fd795 into main Apr 23, 2025
8 checks passed
@wenxi-zeng wenxi-zeng deleted the make-enrichment-closure-a-property-of-event branch April 23, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants