Fix missing region support for 24 sources #7428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forstisabella
added
the
fixed-site
pwseg
previously approved these changes
Feb 6, 2025
forstisabella
dismissed
pwseg’s stale review
The merge-base changed after approval.
pwseg
previously approved these changes
Feb 6, 2025
forstisabella
dismissed
pwseg’s stale review
The merge-base changed after approval.
|
this pr is wigging out - going to close and re-open and see if that helps! |
pwseg
approved these changes
Feb 6, 2025
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As uncovered in this Slack thread, 24/122 of the sources in our docs had incorrect region support: 23 needed EU region support added and 1 needed EU region support removed. This PR fixes that. More PRs to come to handle some other source region weirdness, but here's an initial fix.
Merge timing
asap, ideally!
Related issues (optional)
DOC-1036