Skip to content

Tony/exclude synthetic log #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Tony/exclude synthetic log #2376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7309735
Exclude synthetic logs from receipts returned by eth_
codchen Sep 1, 2025
7a5c113
fix integration tests
codchen Sep 1, 2025
4df2aa5
Merge branch 'main' into tony/exclude-synthetic-log
Pray4Love1 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion evmrpc/tests/mock_contracts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func mixedLogTesterInitializer() func(ctx sdk.Context, a *app.App) {
}
r, _ := a.EvmKeeper.GetTransientReceipt(ctx, tx.Hash(), 0)

_ = a.EvmKeeper.SetERC20CW20Pointer(ctx,
_ = a.EvmKeeper.SetERC20CW20Pointer(ctx, ...)
"sei18cszlvm6pze0x9sz32qnjq4vtd45xehqs8dq7cwy8yhq35wfnn3quh5sau",
common.HexToAddress(r.ContractAddress))
}
Expand Down
18 changes: 12 additions & 6 deletions evmrpc/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,12 +451,18 @@ func encodeReceipt(ctx sdk.Context, receipt *types.Receipt, decoder sdk.TxDecode
if !foundTx {
return nil, errors.New("failed to find transaction in block")
}
receipt.TransactionIndex = uint32(evmTxIndex) //nolint:gosec
var logs []*ethtypes.Log
if includeSynthetic {
logs = keeper.GetLogsForTx(receipt, uint(logIndexOffset)) //nolint:gosec
} else {
logs = keeper.GetEvmOnlyLogsForTx(receipt, uint(logIndexOffset)) //nolint:gosec
receipt.TransactionIndex = uint32(evmTxIndex) //nolint:gosec

var logs []*ethtypes.Log

// Debug logging can be optionally restored via feature flag
// fmt.Println(len(receipt.Logs))

if includeSynthetic {
logs = keeper.GetLogsForTx(receipt, uint(logIndexOffset)) //nolint:gosec
} else {
logs = keeper.GetEvmOnlyLogsForTx(receipt, uint(logIndexOffset)) //nolint:gosec
}
}
for _, log := range logs {
log.BlockHash = bh
Expand Down