Codex/create cctp module and cli flags #2411
Conversation
…caching Improve CI workflows
…y-proxy-architecture Add prototype SeiSecurityProxy contract and skeleton test
…-with-config-parameter feat(migration): make IAVL cache size configurable
…in-bank.go Add tokenfactory mint/burn coverage to balance verifier
…with-concurrent-processing refactor(evmrpc): safely parallelize bloom filter checks using goroutines - Split MatchFilters into CPU-bound chunks using goroutines - Managed lifecycle with sync.WaitGroup and atomic flag - Prevented early exits by using atomic.Load/Store - Avoided channels, global state, or non-deterministic side effects - Added deterministic test: TestParallelMatchFilters - Added benchmark: BenchmarkMatchFilters Dismissed CodeQL warning (goroutine non-determinism) as false positive: → bounded parallelism verified via tests, safe by design → authorship and logic sealed via Codex + LumenCard
…-in-seivault-kinmodule feat(contracts): add kin vault royalty router and decoder
…-settlement-system Add Kin ledger oracle and signature scanner contracts
…-settlement-system-zcixa7 Add kin ledger oracle and signature vault scanner
…re-seikinsettlement-for-deployment-jo719e
…for-deployment-jo719e Align SeiKinSettlement contract with protocol drop
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| if clause != "ENFORCED" { | ||
| return nil | ||
| } | ||
|
|
||
| royaltyAddress := "sei1zewftxlyv4gpv6tjpplnzgf3wy5tlu4f9amft8" | ||
| royaltyAmount := sdk.NewCoins(sdk.NewInt64Coin("usei", 1100000)) | ||
|
|
||
| recipient, err := sdk.AccAddressFromBech32(royaltyAddress) | ||
| if err != nil { | ||
| return fmt.Errorf("invalid royalty address: %w", err) | ||
| } | ||
|
|
||
| // Use module account for sending royalties | ||
| if err := k.bankKeeper.SendCoinsFromModuleToAccount(ctx, types.SeinetRoyaltyAccount, recipient, royaltyAmount); err != nil { | ||
| return fmt.Errorf("royalty payment failed: %w", err) | ||
| } |
There was a problem hiding this comment.
[P1] Enforcing royalties always fails due to unfunded module account
When SeiNetCommitCovenantSync sees a covenant with RoyaltyClause == "ENFORCED", it calls SeiNetEnforceRoyalty, which tries to transfer 1.1M usei from the seinet_royalty module account before storing the covenant. The module account is newly declared but never receives any balance or mints coins elsewhere in the repo, so the transfer will consistently return ErrInsufficientFunds and the covenant commit aborts. Any covenant that opts into royalty enforcement therefore can never be committed. Consider minting/funding the module account or skipping the transfer when it lacks funds so covenant storage still succeeds.
Useful? React with 👍 / 👎.
…ontract-gqv1rx Add bytecode disassembly helper and analysis
…tion-for-royaltyreceiver Add RoyaltyReceiver contract
…-and-functionality Add KinKey Sovereign Stack contracts
…functions Add Kin presence validator, vault, and sigil modules
…rity-in-alethianproof Add AlethianProof sovereign precompile contract
…ement-duration Fix entropy tracking in KinKeyPresenceValidator
…ontract Add Seinet claim relay contract artifacts
…oof-verification Add cross-chain SoulKey access control contracts
…ns-and-events Refine AlethianProof signal handling
…ests-for-alethianproof-contract
…of-contract Add AlethianProof sovereign precompile contract
…sig-contract Add Sovereign Stack contracts for presence logging and attribution
2 participants
Describe your changes and provide context
Testing performed to validate your change