Expand proposal gossip and handling validation rules #2427
+147
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compared to the original Tendermint, Sei-Tendermint expands the proposal structure to include a number of additional fields. Update the basic validation logic to take into account additional fields when validating proposals. Add validation to both direct message handling and ambient gossip handling to avoid propagation of an invalid proposal. Expand tests to cover the additional execution paths at unit and reactor integration level.
sei-will
approved these changes
Oct 2, 2025
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #2427 +/- ##
===========================================
- Coverage 53.88% 40.23% -13.65%
===========================================
Files 1003 1531 +528
Lines 96876 156229 +59353
===========================================
+ Hits 52201 62862 +10661
- Misses 40914 88655 +47741
- Partials 3761 4712 +951
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
yzang2019
approved these changes
Oct 7, 2025
|
Marking as draft to reflect on additional feedback re duplicate validation execution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port-over of the original work done in sei-protocol/sei-tendermint#292
Relates to:
sei-tendermintintosei-chainas mono repo #2421