config: update sei-tendermint default configs #2434
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (47.20%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
===========================================
+ Coverage 40.15% 51.49% +11.34%
===========================================
Files 1531 1541 +10
Lines 156208 156504 +296
===========================================
+ Hits 62718 80593 +17875
+ Misses 88785 69827 -18958
- Partials 4705 6084 +1379
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| func DefaultValidatorConfig() *Config { | ||
| cfg := DefaultConfig() | ||
| cfg.Mode = ModeValidator | ||
| cfg.TxIndex.Indexer = []string{"null"} |
There was a problem hiding this comment.
I am curious; why? What happens if the slice is left to be nil?
There was a problem hiding this comment.
haha, that's the funny part: if it is nil or empty slice, then it defaults to {"kv"}. Ugly as hell.
There was a problem hiding this comment.
@udpatil should we update the underlying map 😂？
sei-tendermint/config/config.go
Outdated
| SendRate: 20971520, // 20 MB/s per connection | ||
| RecvRate: 20971520, // 20 MB/s per connection |
There was a problem hiding this comment.
| SendRate: 20971520, // 20 MB/s per connection | |
| RecvRate: 20971520, // 20 MB/s per connection | |
| SendRate: 20971520, // 20 MiB/s per connection | |
| RecvRate: 20971520, // 20 MiB/s per connection |
3 participants
Describe your changes and provide context
Testing performed to validate your change