-
Notifications
You must be signed in to change notification settings - Fork 854
Integrate UCI version tagging #2445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add UCI workflows to integrate version checking and version tagging/release/publish.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2445 +/- ##
==========================================
- Coverage 53.88% 51.59% -2.30%
==========================================
Files 1003 1541 +538
Lines 96876 156511 +59635
==========================================
+ Hits 52203 80749 +28546
- Misses 40910 69675 +28765
- Partials 3763 6087 +2324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
@@ -0,0 +1,3 @@ | |||
{ | |||
"version": "v6.1.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the next version tag we want? Will that be conflict with existing tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1: https://github.com/sei-protocol/sei-chain/releases - if it default to doing nothing if an existing tag exists, then lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That tag already exists, and because it already exists the UCI does nothing.
This PR simply integrates the UCI versioning. It will not make a tag or a release because both are already present:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did the same for sei-db
@yzang2019 and here is the build on merge to main: https://github.com/sei-protocol/sei-db/actions/runs/18166672464/job/51710684253
As you can see, tag/release creation is skipped because the tag was already present.
Add UCI workflows to integrate version checking and version tagging/release/publish.