Delete future zeroed out state from chain state #2446
Merged
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2446 +/- ##
==========================================
- Coverage 53.88% 51.56% -2.33%
==========================================
Files 1003 1541 +538
Lines 96876 156516 +59640
==========================================
+ Hits 52201 80702 +28501
- Misses 40914 69721 +28807
- Partials 3761 6093 +2332
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
yzang2019
reviewed
Oct 6, 2025
| func (k *Keeper) SetState(ctx sdk.Context, addr common.Address, key common.Hash, val common.Hash) { | ||
| k.PrefixStore(ctx, types.StateKey(addr)).Set(key[:], val[:]) | ||
| store := k.PrefixStore(ctx, types.StateKey(addr)) | ||
| if val == (common.Hash{}) { |
sei-will
approved these changes
Oct 7, 2025
yzang2019
approved these changes
Oct 7, 2025
codchen
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
If a user zeroes out a storage slot, we should actually delete the key/value from our chain state instead of just setting it to zero. This will reduce our total chain state over time.
Testing performed to validate your change
unit tests + integration tests.