Skip to content

Conversation

pompon0
Copy link
Contributor

@pompon0 pompon0 commented Sep 22, 2025

If a node is even just 1 block behind, his peers will start to spam random block parts at him which

  • saturates the network
  • kicks out other msgs from the outbound queue (because block parts are the highest priority messages)
  • OOMs the node - it is unable to process all the incoming parts and the parts are large.
    All this behavior was observed on a 50-node 1-region cluster with 1000txs/s (with lifted limits on the block size).

Fix boils down to properly marking the block parts as sent, so that they are not retransmitted indefinitely.

Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.25%. Comparing base (02c9462) to head (442257a).

Files with missing lines Patch % Lines
internal/consensus/reactor.go 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
- Coverage   57.31%   57.25%   -0.07%     
==========================================
  Files         257      257              
  Lines       34597    34599       +2     
==========================================
- Hits        19829    19808      -21     
- Misses      13180    13204      +24     
+ Partials     1588     1587       -1     
Files with missing lines Coverage Δ
internal/consensus/reactor.go 57.27% <50.00%> (-1.75%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants