Skip to content

Conversation

pompon0
Copy link
Contributor

@pompon0 pompon0 commented Oct 1, 2025

We have 1 transport implementation and it should be used everywhere instead of being mocked out.
Removed the "memory" addressing and "Protocol" altogether. Only TCP addresses are valid now.

Copy link

github-actions bot commented Oct 1, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 1, 2025, 2:50 PM

@pompon0 pompon0 marked this pull request as draft October 1, 2025 14:11
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 85.26316% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.86%. Comparing base (3f7dfae) to head (acba1c9).
⚠️ Report is 2 commits behind head on gprusak-reapply.

Files with missing lines Patch % Lines
internal/p2p/transport.go 84.09% 20 Missing and 8 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           gprusak-reapply     #328      +/-   ##
===================================================
- Coverage            56.88%   56.86%   -0.02%     
===================================================
  Files                  255      254       -1     
  Lines                33830    33734      -96     
===================================================
- Hits                 19245    19184      -61     
+ Misses               13049    13019      -30     
+ Partials              1536     1531       -5     
Files with missing lines Coverage Δ
internal/p2p/address.go 89.55% <100.00%> (-5.87%) ⬇️
internal/p2p/router.go 75.10% <100.00%> (-0.65%) ⬇️
node/setup.go 69.38% <100.00%> (ø)
internal/p2p/transport.go 84.15% <84.09%> (+13.42%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant