Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Commit

Permalink
Add lint command and npmignore to reduce bundle
Browse files Browse the repository at this point in the history
  • Loading branch information
@seia-soto
seia-soto committed Feb 22, 2021
1 parent d5ec472 commit 07956d3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .npmignore
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/.github
/example
/scripts
/README.md
/LICENSE
/.eslintrc.js
1 change: 1 addition & 0 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"license": "MIT",
"types": "src/index.d.ts",
"scripts": {
"lint": "eslint --ext .js,.ts",
"example": "node example",
"profile": "node scripts/profile"
},
Expand Down

5 comments on commit 07956d3

@dvlkv
Copy link
Collaborator

@dvlkv dvlkv commented on 07956d3 Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now eslint ignores .d.ts files, as you can see in .eslintrc.js
You can configure typescript-eslint plugin for this purposes

@seia-soto
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask your opinion if typescript-eslint will be better choice than standard-js-with-typescript?

@dvlkv
Copy link
Collaborator

@dvlkv dvlkv commented on 07956d3 Feb 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

standard-js-with-typescript is extended eslint-config-standard with rules from typescript-eslint.
Feel free to use it, it is easier to setup than bare typescript-eslint

@seia-soto
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you’re better to manage TypeScript environment for this project. I am only able to handle few TypeScript features, so I want to invite you as maintainer of this project. How do you think?

@dvlkv
Copy link
Collaborator

@dvlkv dvlkv commented on 07956d3 Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can help you with typescript. Thank you for invitation

Please sign in to comment.