Make message decoding more interoperable for signature verification #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure that the encoding used for the signed attributes is the one specified in the original message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the encoding used for the signed attributes is the one specified in the original message
Reason behind that:
As a result, verification fails because the hash of the signed attributes does not match the signature, since the signed attributes have been rebuilt.
More information there: PKCS#7 / CMS Signature validation failure with unordered attributes bcgit/bc-java#1365
The current PR allows to retrieve the "raw" signed attributes, coming from the request, instead of rebuilding them for signature verification.