Cleanup of Packet::createFirstLayer
#1981
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re left to be handled by the tail PayloadHeader, instead of being duplicated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1981 +/- ##
==========================================
+ Coverage 83.45% 83.46% +0.01%
==========================================
Files 311 311
Lines 54923 54904 -19
Branches 11844 11818 -26
==========================================
- Hits 45837 45827 -10
+ Misses 7848 7836 -12
- Partials 1238 1241 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new PayloadLayer(...)calls. If all validations for a link layer fail, it exits the case statement and the payload layer is created by the tail call. IMO, that is easier to read than the multiline ternary operator + static casts calls.