Deb package for fake udev library#217
Merged
ehfd merged 2 commits intoselkies-project:mainfrom Feb 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Debian packaging support for the fake-udev addon (including optional 32-bit builds on amd64) and updates the example container to install and preload the fake libudev alongside the joystick interposer.
Changes:
- Add
fake-udevdeb packaging via abuild.shscript and a newDockerfile.debpkg. - Extend
fake-udevMakefile to support 32-bit builds (all32) on amd64. - Update example entrypoints and Dockerfile to install the fake-udev deb and add it to
LD_PRELOAD, plus create/dev/inputdevice nodes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| addons/fake-udev/build.sh | New script to build and package fake-udev into a .deb (and optionally include i386 build on amd64). |
| addons/fake-udev/Makefile | Makefile updates to allow overriding LIB_VERSION and add 32-bit build targets. |
| addons/fake-udev/Dockerfile.debpkg | New build image to produce the .deb/.tar.gz artifacts for fake-udev. |
| addons/example/selkies-entrypoint.sh | Preload fake libudev alongside the joystick interposer. |
| addons/example/entrypoint.sh | Preload fake libudev and create joystick + event device nodes. |
| addons/example/Dockerfile | Install fake-udev deb from an external build image stage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
I think many of the Copilot reviews are irrelevant, but a few, I think it's relevant. |
- Created debain package for fake libudev similar to joystick interposer. - Added support for 32bit build for udev library. - Updated entryfiles and example image to reflect the library changes along with respective env variables.
Member
Author
|
@ehfd addressed the comments that felt relevant. |
ehfd
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference the issue numbers and reviewers
@ehfd @thelamer
Explain relevant issues and how this pull request solves them
This PR aims to integrate joystick interposer into example containe by incorporating recent changes to fake-udev library.
Describe the changes in code and its dependencies and justify that they work as intended after testing
Changes to fake-udev component for 32bit arch (for amd64) build, packaging the library to debain package, updating entryfiles to reflect these modifications.
Describe alternatives you've considered
NA
Additional context
NA