Skip to content

Deb package for fake udev library#217

Merged
ehfd merged 2 commits intoselkies-project:mainfrom
PMohanJ:udev
Feb 11, 2026
Merged

Deb package for fake udev library#217
ehfd merged 2 commits intoselkies-project:mainfrom
PMohanJ:udev

Conversation

@PMohanJ
Copy link
Member

@PMohanJ PMohanJ commented Feb 11, 2026

Reference the issue numbers and reviewers
@ehfd @thelamer

Explain relevant issues and how this pull request solves them
This PR aims to integrate joystick interposer into example containe by incorporating recent changes to fake-udev library.

Describe the changes in code and its dependencies and justify that they work as intended after testing
Changes to fake-udev component for 32bit arch (for amd64) build, packaging the library to debain package, updating entryfiles to reflect these modifications.

Describe alternatives you've considered
NA

Additional context
NA

  • I confirm that this pull request is relevant to the scope of this project. If you know that upstream projects are the cause of this problem, please file the pull request there.
  • I confirm that this pull request has been tested thoroughly and to the best of my knowledge that additional unintended problems do not arise.
  • I confirm that the style of the changed code conforms to the overall style of the project.
  • I confirm that I have read other open and closed pull requests and that duplicates do not exist.
  • I confirm that I have justified the need for this pull request and that the changes reflect the fix for the specified problem.
  • I confirm that no portion of this pull request contains credentials or other private information, and it is my own responsibility to protect my privacy.
  • I confirm that the authors of this pull request does not willfully breach or infringe legal regulations, in any and all global law, regarding trademarks, trade names, logos, patents, or any and all other forms of external intellectual property, as well as adhering to software license terms of open-source and proprietary software projects.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Debian packaging support for the fake-udev addon (including optional 32-bit builds on amd64) and updates the example container to install and preload the fake libudev alongside the joystick interposer.

Changes:

  • Add fake-udev deb packaging via a build.sh script and a new Dockerfile.debpkg.
  • Extend fake-udev Makefile to support 32-bit builds (all32) on amd64.
  • Update example entrypoints and Dockerfile to install the fake-udev deb and add it to LD_PRELOAD, plus create /dev/input device nodes.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
addons/fake-udev/build.sh New script to build and package fake-udev into a .deb (and optionally include i386 build on amd64).
addons/fake-udev/Makefile Makefile updates to allow overriding LIB_VERSION and add 32-bit build targets.
addons/fake-udev/Dockerfile.debpkg New build image to produce the .deb/.tar.gz artifacts for fake-udev.
addons/example/selkies-entrypoint.sh Preload fake libudev alongside the joystick interposer.
addons/example/entrypoint.sh Preload fake libudev and create joystick + event device nodes.
addons/example/Dockerfile Install fake-udev deb from an external build image stage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ehfd
Copy link
Member

ehfd commented Feb 11, 2026

I think many of the Copilot reviews are irrelevant, but a few, I think it's relevant.

- Created debain package for fake libudev similar to joystick interposer.
- Added support for 32bit build for udev library.
- Updated entryfiles and example image to reflect the library changes along
  with respective env variables.
@PMohanJ
Copy link
Member Author

PMohanJ commented Feb 11, 2026

@ehfd addressed the comments that felt relevant.

@ehfd ehfd merged commit de4a774 into selkies-project:main Feb 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants