Skip to content

feat: add option to publish to CI catalog #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 585 commits into
base: next
Choose a base branch
from
Draft

feat: add option to publish to CI catalog #842

wants to merge 585 commits into from

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Apr 8, 2025 •
edited
Loading

Related to #822

renovate bot added 30 commits September 13, 2023 23:26
@renovate
chore(deps): update dependency sinon to v16 (#596)
119abe4 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency aggregate-error to v5 (#597)
bf1b490 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency semantic-release to v21.1.2 (#598)
0287804 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency semantic-release to v22 (#599)
b9d89a4 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#595)
7de99d1 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#600)
7287bf6 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency semantic-release to v22.0.1 (#601)
44226ec 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
ci(action): update actions/checkout digest to 8ade135 (#602)
2425f52 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency semantic-release to v22.0.4 (#603)
e47365e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency semantic-release to v22.0.5 (#604)
c132655 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#605)
0880850 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sinon to v16.1.0 (#609)
1f785a2 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency nock to v13.3.4 (#610)
c4c663e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#611)
a92ea8a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sinon to v16.1.1 (#612)
547a1a8 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sinon to v16.1.3 (#613)
36ce5ba 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
ci(action): update actions/checkout digest to b4ffde6 (#614)
d736816 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency nock to v13.3.6 (#615)
6b74dd6 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sinon to v17 (#616)
978f9f1 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#617)
d05a1a1 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
ci(action): update actions/setup-node digest to 1a4442c (#618)
dd45648 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
ci(action): update actions/checkout action to v4.1.1 (#620)
1adce19 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
ci(action): update actions/setup-node action to v3.8.2 (#621)
85c861e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
ci(action): update actions/setup-node action to v4 (#619)
4729335 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#622)
b218ca3 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency nock to v13.3.7 (#623)
ebb6bd3 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency semantic-release to v22.0.6 (#624)
6d70a4c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sinon to v17.0.1 (#625)
97d3521 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency nock to v13.3.8 (#626)
0aa7406 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency semantic-release to v22.0.7 (#627)
b235b00 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
JonasSchubert and others added 23 commits January 13, 2025 17:27
@JonasSchubert
chore(project): merge pull request #809 from semantic-release/fix/pro…
9d34d25 
…ject-id

Use project ID for API calls if available
@renovate
chore(deps): lock file maintenance (#812)
909ca2b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency nock to v14 (#814)
f6787b8 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#815)
afefbe7 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
ci(action): update actions/setup-node action to v4.2.0 (#816)
381c8fc 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#817)
134a455 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency nock to v14.0.1 (#818)
a370f55 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency semantic-release to v24.2.2 (#819)
e29f27d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency prettier to v3.5.0 (#820)
d89f5df 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency prettier to v3.5.1 (#821)
3144c19 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency semantic-release to v24.2.3 (#824)
fcd45ad 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#825)
3d82a8f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency prettier to v3.5.2 (#826)
5c77244 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#827)
271954b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
ci(action): update actions/setup-node action to v4.3.0 (#831)
60996e6 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency prettier to v3.5.3 (#828)
93888cd 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#829)
37045b4 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sinon to v19.0.4 (#832)
eade82c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#833)
234b173 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sinon to v19.0.5 (#834)
aaa6006 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sinon to v20 (#835)
a1a0392 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency nock to v14.0.2 (#837)
eaec8ec 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (#838)
dcd0ab5 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@fgreinacher fgreinacher self-assigned this Apr 8, 2025
@fgreinacher fgreinacher force-pushed the feat/publish-to-catalog branch from cb57c05 to 197c94a Compare April 9, 2025 17:35
@fgreinacher
Copy link
Contributor Author

@JonasSchubert WDYT about doing it like this as a first step?

travi
travi reviewed Apr 9, 2025
View reviewed changes
@fgreinacher fgreinacher changed the base branch from master to next April 10, 2025 05:28
JonasSchubert
JonasSchubert reviewed Apr 11, 2025
View reviewed changes
lib/publish.js
@@ -201,5 +193,15 @@ export default async (pluginConfig, context) => {

const releaseUrl = urlJoin(gitlabUrl, projectPath, `/-/releases/${encodedGitTag}`);

if (publishToCatalog) {
try {
await execa("glab", ["repo", "publish", "catalog", gitTag], { cwd, timeout: 30 * 1000 });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This also introduces execa as a new dependency. What about just using exec from node:child_process? (execa is also not yet listed in package.json or here as import)
  • Also glab respects GITLAB_TOKEN according to their docs. But the plugin allows GL_TOKEN or GITLAB_TOKEN. We should either add a check here and/or highlight this in the README.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @JonasSchubert!

Good point, I just saw execa used in other semenatic-release repos. I'll try with the standard lib instead.

Also good hint with the token, I think we need to pass on our variable to the child process.

I'll be out for the next two weeks, so don't expect any activity here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travi travi travi left review comments

@JonasSchubert JonasSchubert JonasSchubert left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@fgreinacher fgreinacher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fgreinacher @travi @JonasSchubert @mattyclarkson @babblebey @aldenbe @gaidzla