Skip to content

refactor(api): use ky and undici instead of got #756 #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonasSchubert
Copy link
Contributor

Initial draft to move from got to ky (using undici).

@JonasSchubert
Copy link
Contributor Author

  • Tests are failing caused by undicis minimum node version being set to 20.18.1 in this PR.
  • either we also introduce a breaking change by updating our engine to same 20.x.x or higher or we abandon that for now
  • also @ievgennaida made a good point, but instead of mixing undici and ky we could simply use only undici (if we continue this direction)

@travi
Copy link
Member

travi commented Apr 11, 2025

  • we also introduce a breaking change by updating our engine to same 20.x.x or higher

with node v18 going EOL at the end of the month, it is a good time to consider tightening our supported ranges. however, we normally change our support to be limited to only the latest LTS line when we do release a breaking chain, so that goes beyond even the change to undici.

we could simply use only undici

i assume we would then use it through the native fetch inerface built into node rather than using undici as a dependency at that point, right? in that case, the node version requirement seems to go away

i guess the question comes down to whether we see ky as providing some value beyond native fetch or not. i dont have strong feelings either way as long as the path we choose favors maintainability.

@ievgennaida
Copy link

fetch is introduced in v18 as experimental and became stable in Node.js v21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants