Merge beta to master #854
Merge beta to master #854
Conversation
feat: add option to publish to CI catalog
…-missing feat: raise error when GitLab CLI is required but not installed
fgreinacher
force-pushed
the
beta
branch
2 times, most recently
from
6e5d4c1 to
c128fc6
Compare
|
🎉 This PR is included in version 13.3.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Pull Request Overview
This PR merges CI catalog changes from the beta channel to the release channel. Key changes include adding a new "publishToCatalog" option to the configuration, updating tests to cover the catalog publishing logic, and incorporating necessary documentation and error definitions.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/verify.test.js | Added tests to verify error handling when GitLab CLI is missing |
| test/resolve-config.test.js | Updated default configuration to include publishToCatalog |
| test/publish.test.js | Added tests for successful and error scenarios when publishing to the CI catalog |
| package.json | Updated dependencies to support the new functionality |
| lib/verify.js | Added logic to verify GitLab CLI installation for catalog publishing |
| lib/resolve-config.js | Added publishToCatalog to the resolved configuration |
| lib/publish.js | Integrated glab CLI invocation for catalog publishing |
| lib/glab.js | Created a wrapper for calling the glab CLI using execa |
| lib/definitions/errors.js | Added a new error definition for missing GitLab CLI |
| README.md | Documented the experimental publishToCatalog feature |
Comments suppressed due to low confidence (1)
lib/verify.js:95
- The glab function is used in this block but is not imported, which may lead to a runtime error when publishToCatalog is true. Please import glab from './glab.js' at the beginning of the file.
if (publishToCatalog === true) {
|
🎉 This PR is included in version 13.3.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I had a chat with Furkan from GitLab today who brought up a few good ideas. Let's hold this PR back until the way forward is clearer. |
This brings the CI catalog changes from the beta channel to the release channel.
I have successfully verified the new feature: https://gitlab.com/gitlab-org/gitlab/-/issues/463253#note_2509219147
Contributes to #822