fix(sql): do not check of affected rows bacause it can return incorre…

…ct number
semaphoreui · Mar 31, 2024 · ec036fd · ec036fd
1 parent 38bb367
commit ec036fd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 15 deletions.
diff --git a/db/sql/SqlDb.go b/db/sql/SqlDb.go
@@ -61,16 +61,6 @@ func validateMutationResult(res sql.Result, err error) error {
 		return err
 	}
 
-	affected, err := res.RowsAffected()
-
-	if err != nil {
-		return err
-	}
-
-	if affected == 0 {
-		return db.ErrNotFound
-	}
-
 	return nil
 }
 

diff --git a/db/sql/session.go b/db/sql/session.go
@@ -27,10 +27,8 @@ func (d *SqlDb) GetAPIToken(tokenID string) (token db.APIToken, err error) {
 	return
 }
 
-func (d *SqlDb) ExpireAPIToken(userID int, tokenID string) (err error) {
-	res, err := d.exec("update user__token set expired=true where id=? and user_id=?", tokenID, userID)
-
-	return validateMutationResult(res, err)
+func (d *SqlDb) ExpireAPIToken(userID int, tokenID string) error {
+	return validateMutationResult(d.exec("update user__token set expired=true where id=? and user_id=?", tokenID, userID))
 }
 
 func (d *SqlDb) DeleteAPIToken(userID int, tokenID string) (err error) {

diff --git a/web/src/components/KeyForm.vue b/web/src/components/KeyForm.vue
@@ -73,7 +73,7 @@
       v-model="item.ssh.private_key"
       :label="$t('privateKey')"
       :disabled="formSaving || !canEditSecrets"
-      :rules="[v => !!v || $t('private_key_required')]"
+      :rules="[v => !canEditSecrets || !!v || $t('private_key_required')]"
       v-if="item.type === 'ssh'"
     />