-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ansible-semaphore/semaphore#1195 #1221
Conversation
FIX: More indenting then necessary.
Tested this against a locally set up Gitea Git-service. It fails to fetch the repository from the Gitea Git-service when no username is set in the key because it falls back to 'git' as the username. Gitea expects the username to be Gitea.
The fetch succeeds when the username is set to 'Gitea'.
@fiftin Can you review the PR please? |
has that isuue fixed? |
any update on this? not being able to use gitea makes semaphore unusable for me |
Hey, This PR should fix this issue. The maintainers need to merge this PR into the codebase. |
@fiftin I've merged the latest version of the codebase into this PR to solve any merge conflicts. All tests run without any problems. Can you look into this PR and merge it? People really seem to need this fix. |
When using a self-hosted Git service like Gitea there is a need for the SSH-connection to use a different username then 'git'.
This fix will check if the optional username field of the configured SSH-key is set. If it is, it will use the set username when establishing the SSH-connection. When it is not set, it falls back to using 'git' as the username.