Fix language not being recognized correctly #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExplodingDragon
changed the title
|
But your changes break other languages. |
fiftin
reviewed
Mar 27, 2024
|
When an exact match cannot be made, the country code will be removed and the match will continue. The test doesn't seem to be a problem. ru
fr
zh-cn
|
tboerger
approved these changes
Apr 17, 2024
| @@ -670,6 +670,11 @@ const LANGUAGES = { | |||
| function getLangInfo(locale) { | |||
| let res = LANGUAGES[locale]; | |||
|
|
|||
| // failback short i18n | |||
| if (!res) { | |||
| res = LANGUAGES[locale.split('_')[0]]; | |||
There was a problem hiding this comment.
This should catch the case mentioned by @fiftin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
en_UStype language formats.