Rearrange the folder structure to be a library#1
Open
per1234 wants to merge 1 commit intosemihiseri:masterfrom
Open
Rearrange the folder structure to be a library#1per1234 wants to merge 1 commit intosemihiseri:masterfrom
per1234 wants to merge 1 commit intosemihiseri:masterfrom
Conversation
This repository is advertised as a "library for Arduino" but the previous folder structure makes it a sketch, not a library. Rearranging the folder structure allows installation as a library after which this library can be shared between multiple projects by simply #include-ing the header file. The example sketch will appear under File > Examples > libSNMP in the Arduino IDE.
Author
|
Please let me know if there's anything I need to do to get this pull request merged. |
Owner
|
This must've escaped my attention. Have you tested the new folder structure? Because I want to merge it but I don't have the hardware to test it anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository is advertised as a "library for Arduino" but the previous folder structure makes it a sketch, not a library. Rearranging the folder structure allows installation as a library after which this library can be shared between multiple projects by simply
#include-ing the header file. The example sketch will appear under File > Examples > libSNMP in the Arduino IDE.