Skip to content

[UIK-3372][Tag] update styles #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 17, 2025
Merged

[UIK-3372][Tag] update styles #2073

merged 18 commits into from
Apr 17, 2025

Conversation

j-mnizhek
Copy link
Contributor

@j-mnizhek j-mnizhek commented Apr 8, 2025

Motivation and Context

  1. It was necessary to slightly unify and simplify the styles so that the paddings/margins for tags with an addon and with a Circle addon would be consistent. To achieve this, I also adjusted the size of the Circle addons so they fit properly inside tags of different sizes.
  2. Updated a couple of stories for Tag and added another one to make it easier to track changes across all combinations.
  3. Updated playground for Tag so that Circle addon will be set before the default addon.

How has this been tested?

Manually with a help of storybook.

Screenshots (if appropriate):

How it was:
image
image

image

How it's now:
image
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

@j-mnizhek j-mnizhek marked this pull request as ready for review April 8, 2025 12:01
@j-mnizhek
Copy link
Contributor Author

To prevent visual changes for the old usage of the Tag with Close icon, I also made a small update for paddings of SClose.

@ilyabrower ilyabrower changed the base branch from master to major/16 April 17, 2025 13:18
@ilyabrower ilyabrower merged commit 9807ad2 into major/16 Apr 17, 2025
4 of 7 checks passed
@ilyabrower ilyabrower deleted the UIK-3372/update/tag-styles branch April 17, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants