Skip to content

UIK-3021/fullscreen-modal-tests #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2025
Merged

Conversation

Valeria-Zimnitskaya
Copy link
Contributor

@Valeria-Zimnitskaya Valeria-Zimnitskaya commented Apr 15, 2025

  • Moved documentation examples to Storybook
  • Removed unnecessary snapshot tests from unit tests
  • Added accessibility (axe) tests
  • Added test stories to cover props and requirements
  • Added browser tests with snapshots, ARIA attributes, roles, and keyboard navigation checks
  • All browser tests tun in ~30sec

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

@ilyabrower ilyabrower merged commit c514d56 into master Apr 17, 2025
9 checks passed
@ilyabrower ilyabrower deleted the UIK-3021/fullscreen-modal-tests branch April 17, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants