gemspec + delivery_method (+ Added Bearer to Authorization header) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyObtiva
changed the title
|
|
|
Hey @AndyObtiva, is this still working? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I setup project for submitting to rubygem and generated a gemspec for it. This was done using Jeweler and Bundler. Also incorporated authorization bearer to fix issue with token used in API requests (as per #5). Thank you very much for providing this library. You should be able to submit as a rubygem by pulling this pull request into your local directory, merging, and running "rake release". Let me know if you need any help with this as I have released many gems in the past. I look forward to future versions of this library.
p.s. I tested the gem hosted on my github fork using this line in a project Gemfile:
It worked! In the future, developers should be able to just reference the gem once released as follows:
or
Finally, a Rails ActionMailer delivery_method (
:sendpulse) has been added to leverage the sendpulse-rest-api-ruby for email sending in Rails with minimal setup. Details are found in the updatedREADME.md