Add ruby 3.4 and rubyzip 3 support#204
Conversation
`rubyzip` v3 has different syntax: - https://github.com/rubyzip/rubyzip/releases/tag/v3.0.0 - https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x Fix tests related to ruby 3.4 hash inspect and add ruby 3.4 to the build
bliof
force-pushed
the
ruby-3.4-and-rubyzip-3
branch
from
4e98cfa to
bbff81a
Compare
lib/sablon/configuration/html_tag.rb:94: warning: string returned by :paragraph.to_s will be frozen in the future
bliof
force-pushed
the
ruby-3.4-and-rubyzip-3
branch
2 times, most recently
from
66add28 to
ecbbbfe
Compare
|
@senny 👀 Small change for supporting rubyzip 3.x, does it look ok to you? |
|
Hi @bliof, sorry for the long response time. Unfortunately, the library is no longer actively maintained and I have no more projects available to vet changes to the code and ensure things continue to function. For that reason, I'm quite hesitant to merge changes and cause potential breaking changes that I will be unable to fix. Thank you for your work and I'm sure there are others that can benefit from your patch to report back if things work with rubyzip 3.0. If we have enough evidence that this doesn't cause problems I'm open to merging the batch and cutting a new gem release. |
|
+1. Works for my basic use case. |
|
Thank you @bliof! Works for me as well, even with Ruby < 3.4. |
|
Works for me as well without issues. Thank you @bliof |
|
@senny It seems the change has been sufficiently reviewed. When you have a moment, you can ship the new version 🚀🙇 |
bliof
force-pushed
the
ruby-3.4-and-rubyzip-3
branch
from
ecbbbfe to
941cfb1
Compare
|
Many thanks @bliof and everyone who tested the patch. I have uploaded |
5 participants
rubyzipv3 has different syntax:Fix tests related to ruby 3.4 hash inspect and add ruby 3.4 to the build
Fix warning about
.to_swill be frozen in the futureCloses #203