Fix Google Docs compatibility by suppressing Zip64 extra fields#208
Open
bliof wants to merge 2 commits intosenny:masterfrom
Open
Fix Google Docs compatibility by suppressing Zip64 extra fields#208bliof wants to merge 2 commits intosenny:masterfrom
bliof wants to merge 2 commits intosenny:masterfrom
Conversation
bliof
force-pushed
the
fix-google-docs-issue
branch
from
4588926 to
95c65f3
Compare
rubyzip 3.x enables Zip64 by default, adding extra fields to zip entries that cause docx files to fail opening in Google Docs/Drive. Suppress Zip64 extra fields using rubyzip 3.2.0's suppress_extra_fields option For rubyzip 3.0/3.1 users, `Zip.write_zip64_support = false` can be used instead.
The rubyzip bump is as per the recommendation of the project: https://github.com/rubyzip/rubyzip/tree/v3.2.2?tab=readme-ov-file#requirements > Version 3.x requires at least Ruby 3.0. > Version 2.x requires at least Ruby 2.4, and is known to work on Ruby 3.x. > It is not recommended to use any versions of Rubyzip earlier than 2.3 due to security issues.
bliof
force-pushed
the
fix-google-docs-issue
branch
from
95c65f3 to
70f7e53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rubyzip 3.x enables Zip64 by default, adding extra fields to zip entries that cause docx files to fail opening in Google Docs/Drive.
Suppress Zip64 extra fields using rubyzip 3.2.0's suppress_extra_fields option
For rubyzip 3.0/3.1 users,
Zip.write_zip64_support = falsecan be used instead.Closes #207