add arduino_functions block restriction and improvement of board-spec… #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests
Github Test Reporter by CTRF 💚 |
Tests
Github Test Reporter by CTRF 💚 |
Tests
Github Test Reporter by CTRF 💚 |
|
– Implementation of detailed backpack configuration with custom options and event handlers. |
Tests
Github Test Reporter by CTRF 💚 |
Thiemann96
requested changes
May 12, 2025
cypress/e2e/code-editor.cy.js
Outdated
| cy.get("button").contains("Reset code").click(); | ||
| cy.get("button").contains("Zurücksetzen").should("exist"); | ||
| cy.get("button").contains(/Reset code|Code zurücksetzen/).click(); | ||
| cy.get("button").contains(/Reset|Zurücksetzen/).should("exist"); |
There was a problem hiding this comment.
Nach meinem Gewissen war es sinnvoll, statt harter String Regex-Matches zu benutzen.
Denn mit harten Strings wäre der Test bei einer minimalen Veränderung durchgefallen. Somit wird zum Beispiel der Fall abgedeckt, wenn der Button nur Reset woanders im Projekt heißen würde.
|
|
||
| this.isEditable = function() { | ||
| return false; | ||
| }; |
There was a problem hiding this comment.
Was hält dich davon ab einfach this.isEditable = false zu schreiben? Warum brauch es diesen Funktionsaufruf?
There was a problem hiding this comment.
Weil ich es für sinnvoll hielt, isEditable als Methode zu schreiben wegen des dynamischen Verhaltens bzw. der Eigenschaft, statt statisch. Warum wäre statisches Verhalten besser?
src/components/Blockly/msg/de_old.js
Outdated
| Blockly.Msg.REMOVE_FROM_BACKPACK = "Entfernen aus Rucksack"; | ||
| Blockly.Msg.COPY_TO_BACKPACK = "Kopieren in Rucksack"; | ||
| Blockly.Msg.COPY_ALL_TO_BACKPACK = "Alle Kopieren in Rucksack"; | ||
| Blockly.Msg.PASTE_ALL_FROM_BACKPACK = "Alle Einfügen aus Rucksack"; |
There was a problem hiding this comment.
Die Texte müssen nicht in die ..old.js Dateien geschrieben werden ;) (ich weiß hatte ich dir mal anders gesagt, aber vergiss das)
georgi-s
added a commit
that referenced
this pull request
May 16, 2025
…ific instance limits
- Test now searches for both possible reset button texts
- Supports both English ("Reset code") and German ("Code zurücksetzen") translations
- Uses regular expressions for flexible text searches
- Improves the robustness of the test across different language settings
- Test now searches for both possible reset button texts
- Supports both English ("Reset code") and German ("Code zurücksetzen") translations
- Uses regular expressions for flexible text searches
- Improves the robustness of the test across different language settings
georgi-s
force-pushed
the
fix/backpack-usage-#346
branch
from
5f68eb8 to
dab5f29
Compare
Tests
Github Test Reporter by CTRF 💚 |
…Komponente eine funktion erwartet.
Tests
Github Test Reporter by CTRF 💚 |
Thiemann96
pushed a commit
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ific instance limits
Adds security measures for the arduino_functions block:
These changes ensure that the arduino_functions block, which contains the setup() and loop() functions, can only exist once in the workspace and cannot be accidentally tampered with.