Skip to content

fix issue where network errors were not retried #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix issue where network errors were not retried #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c51297
fix issue where network errors were not retried
guss84 Sep 24, 2024
71ccf07
Merge branch 'master' into fix/retry-network-error
guss84 Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/utils/axiosInterceptors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,26 @@ const retryRequests = (err: any): any => {
return Promise.reject(err);
};

const shouldRetry = (error: AxiosError): boolean => {
// error.response is not always defined, as the error could be thrown before we get a response from the server
// https://github.com/axios/axios/issues/960#issuecomment-398269712
if (!error.response || !error.response.status) {
const isNetworkError = (error: AxiosError): boolean => {
const CODE_EXCLUDE_LIST = ['ERR_CANCELED', 'ECONNABORTED'];

if (error.response) {
return false;
}
if (!error.code) {
return false;
}
return error.response.status == 429 || (error.response.status >= 500 && error.response.status <= 599);
return !CODE_EXCLUDE_LIST.includes(error.code);
};

const shouldRetry = (error: AxiosError): boolean => {
console.log(error);
return (
isNetworkError(error) ||
!error.response ||
error.response.status === 429 ||
(error.response.status >= 500 && error.response.status <= 599)
);
};

export const addAxiosRequestInterceptor = (
Expand Down
Loading