-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: example app #21
Draft
johannes-lindgren
wants to merge
21
commits into
main
Choose a base branch
from
tests/example-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
@sep2 I'm converting to draft, because I am working on this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic example application for two purposes:
Testing
A simple test to test that:
If there's an issue, the dependent React application will fail to type check and build.
Documentation
As a demo to draw inspiration from. When using this library for the first time, I found the barrier to entry to be a bit higher than necessary. The idea is to demonstrate:
binder<T>()
, Immer-yjs essentially asserts the type. However, the user might want to validate the document to guarantee proper type safety. (I developed a validation library just for this purpose—PureParse—to deal specifically with data from CRDTs)useSyncExternalStoreWithSelector
: React now hasuseSyncExternalStore
.