Endpoint slices bug fix #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarcinski
reviewed
Jun 30, 2025
| freq time.Duration | ||
|
|
||
| // Track all endpoint slices for this service | ||
| endpointSlicesMu sync.RWMutex |
There was a problem hiding this comment.
As far as I understand the code, only one goroutine handles events, so we don't have to synchronize using a mutex.
Comment on lines
+322
to
+329
| var allAddresses []resolver.Address | ||
| totalEndpoints := 0 | ||
|
|
||
| for _, slice := range k.endpointSlices { | ||
| addrs := k.makeAddresses(slice) | ||
| allAddresses = append(allAddresses, addrs...) | ||
| totalEndpoints += len(slice.Endpoints) | ||
| } |
There was a problem hiding this comment.
According to the documentation https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/#duplicate-endpoints endpoints can be duplicated, which means we should deduplicate them
Comment on lines
+288
to
+295
| if sliceName == "" { | ||
| // Fallback: generate name from first endpoint if metadata is missing | ||
| if len(event.Object.Endpoints) > 0 && len(event.Object.Endpoints[0].Addresses) > 0 { | ||
| sliceName = fmt.Sprintf("slice-%s", event.Object.Endpoints[0].Addresses[0]) | ||
| } else { | ||
| sliceName = fmt.Sprintf("slice-%d", len(k.endpointSlices)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Due to the fact that endpoints can be duplicated, I think that using a hashmap with keys based on endpoints might not work.
lothar1998
reviewed
Jun 30, 2025
| defer k.endpointSlicesMu.Unlock() | ||
|
|
||
| sliceName := event.Object.Metadata.Name | ||
| if sliceName == "" { |
There was a problem hiding this comment.
I'm pretty sure that endpoint slice name has to be present. If it is absent, then we should probably ignore such event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix #66