Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion serde_core/src/crate_root.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ macro_rules! crate_root {
pub use self::core::fmt::{self, Debug, Display, Write as FmtWrite};
pub use self::core::marker::PhantomData;
pub use self::core::num::Wrapping;
pub use self::core::ops::{Bound, Range, RangeFrom, RangeInclusive, RangeTo};
pub use self::core::ops::{
Bound, Range, RangeFrom, RangeFull, RangeInclusive, RangeTo, RangeToInclusive,
};
pub use self::core::result;
pub use self::core::time::Duration;

Expand Down
181 changes: 181 additions & 0 deletions serde_core/src/de/impls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2870,6 +2870,187 @@ mod range_to {

////////////////////////////////////////////////////////////////////////////////

impl<'de> Deserialize<'de> for RangeFull {
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
where
D: Deserializer<'de>,
{
struct RangeFullVisitor;

impl<'de> Visitor<'de> for RangeFullVisitor {
type Value = RangeFull;

fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
formatter.write_str("struct RangeFull")
}

fn visit_unit<E>(self) -> Result<Self::Value, E>
where
E: Error,
{
Ok(..)
}

fn visit_seq<A>(self, _seq: A) -> Result<Self::Value, A::Error>
where
A: SeqAccess<'de>,
{
Ok(..)
}

fn visit_map<A>(self, _map: A) -> Result<Self::Value, A::Error>
where
A: MapAccess<'de>,
{
Ok(..)
}
}

deserializer.deserialize_struct("RangeFull", &[], RangeFullVisitor)
}
}

////////////////////////////////////////////////////////////////////////////////

// Similar to:
//
// #[derive(Deserialize)]
// #[serde(deny_unknown_fields)]
// struct RangeToInclusive<Idx> {
// end: Idx,
// }
impl<'de, Idx> Deserialize<'de> for RangeToInclusive<Idx>
where
Idx: Deserialize<'de>,
{
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
where
D: Deserializer<'de>,
{
let end = tri!(deserializer.deserialize_struct(
"RangeToInclusive",
range_to_inclusive::FIELDS,
range_to_inclusive::RangeToInclusiveVisitor {
expecting: "struct RangeToInclusive",
phantom: PhantomData,
},
));
Ok(..=end)
}
}

mod range_to_inclusive {
use crate::lib::*;

use crate::de::{Deserialize, Deserializer, Error, MapAccess, SeqAccess, Visitor};
use crate::private;

pub const FIELDS: &[&str] = &["end"];

// If this were outside of the serde crate, it would just use:
//
// #[derive(Deserialize)]
// #[serde(field_identifier, rename_all = "lowercase")]
enum Field {
End,
}

impl<'de> Deserialize<'de> for Field {
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
where
D: Deserializer<'de>,
{
struct FieldVisitor;

impl<'de> Visitor<'de> for FieldVisitor {
type Value = Field;

fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
formatter.write_str("`end`")
}

fn visit_str<E>(self, value: &str) -> Result<Self::Value, E>
where
E: Error,
{
match value {
"end" => Ok(Field::End),
_ => Err(Error::unknown_field(value, FIELDS)),
}
}

fn visit_bytes<E>(self, value: &[u8]) -> Result<Self::Value, E>
where
E: Error,
{
match value {
b"end" => Ok(Field::End),
_ => {
let value = private::string::from_utf8_lossy(value);
Err(Error::unknown_field(&*value, FIELDS))
}
}
}
}

deserializer.deserialize_identifier(FieldVisitor)
}
}

pub struct RangeToInclusiveVisitor<Idx> {
pub expecting: &'static str,
pub phantom: PhantomData<Idx>,
}

impl<'de, Idx> Visitor<'de> for RangeToInclusiveVisitor<Idx>
where
Idx: Deserialize<'de>,
{
type Value = Idx;

fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {
formatter.write_str(self.expecting)
}

fn visit_seq<A>(self, mut seq: A) -> Result<Self::Value, A::Error>
where
A: SeqAccess<'de>,
{
let end: Idx = match tri!(seq.next_element()) {
Some(value) => value,
None => {
return Err(Error::invalid_length(0, &self));
}
};
Ok(end)
}

fn visit_map<A>(self, mut map: A) -> Result<Self::Value, A::Error>
where
A: MapAccess<'de>,
{
let mut end: Option<Idx> = None;
while let Some(key) = tri!(map.next_key()) {
match key {
Field::End => {
if end.is_some() {
return Err(<A::Error as Error>::duplicate_field("end"));
}
end = Some(tri!(map.next_value()));
}
}
}
let end = match end {
Some(end) => end,
None => return Err(<A::Error as Error>::missing_field("end")),
};
Ok(end)
}
}
}

////////////////////////////////////////////////////////////////////////////////

impl<'de, T> Deserialize<'de> for Bound<T>
where
T: Deserialize<'de>,
Expand Down
30 changes: 30 additions & 0 deletions serde_core/src/ser/impls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,36 @@ where

////////////////////////////////////////////////////////////////////////////////

impl Serialize for RangeFull {
fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
where
S: Serializer,
{
use super::SerializeStruct;
let state = tri!(serializer.serialize_struct("RangeFull", 0));
state.end()
}
}

////////////////////////////////////////////////////////////////////////////////

impl<Idx> Serialize for RangeToInclusive<Idx>
where
Idx: Serialize,
{
fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
where
S: Serializer,
{
use super::SerializeStruct;
let mut state = tri!(serializer.serialize_struct("RangeToInclusive", 1));
tri!(state.serialize_field("end", &self.end));
state.end()
}
}

////////////////////////////////////////////////////////////////////////////////

impl<T> Serialize for Bound<T>
where
T: Serialize,
Expand Down
36 changes: 36 additions & 0 deletions test_suite/tests/test_de.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1937,6 +1937,42 @@ fn test_range_to() {
);
}

#[test]
fn test_range_full() {
test(
..,
&[
Token::Struct {
name: "RangeFull",
len: 0,
},
Token::StructEnd,
],
);
test(.., &[Token::Seq { len: Some(0) }, Token::SeqEnd]);
test(.., &[Token::Unit]);
}

#[test]
fn test_range_to_inclusive() {
test(
..=2u32,
&[
Token::Struct {
name: "RangeToInclusive",
len: 1,
},
Token::Str("end"),
Token::U32(2),
Token::StructEnd,
],
);
test(
..=2u32,
&[Token::Seq { len: Some(1) }, Token::U32(2), Token::SeqEnd],
);
}

#[test]
fn test_bound() {
test(
Expand Down
30 changes: 30 additions & 0 deletions test_suite/tests/test_ser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,36 @@ fn test_range_to() {
);
}

#[test]
fn test_range_full() {
assert_ser_tokens(
&(..),
&[
Token::Struct {
name: "RangeFull",
len: 0,
},
Token::StructEnd,
],
);
}

#[test]
fn test_range_to_inclusive() {
assert_ser_tokens(
&(..=2u32),
&[
Token::Struct {
name: "RangeToInclusive",
len: 1,
},
Token::Str("end"),
Token::U32(2),
Token::StructEnd,
],
);
}

#[test]
fn test_bound() {
assert_ser_tokens(
Expand Down