feat: add stopAutoPlayOnTouch option to CarouselSlider #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new option 'stopAutoPlayOnTouch' that permanently stops autoplay when user interacts with the carousel, unlike 'pauseAutoPlayOnTouch' which resumes after interaction. The stop option takes precedence over pause for better control. - Add stopAutoPlayOnTouch property to CarouselOptions - Implement priority logic where stop overrides pause behavior - Update onPanDown/onPanUp to handle stop vs pause correctly - Add .serena/ to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new option
stopAutoPlayOnTouchto the CarouselSlider that allows users to permanently stop autoplay when they interact with the carousel, unlikepauseAutoPlayOnTouchwhich resumes after interaction.Changes
stopAutoPlayOnTouchproperty toCarouselOptions(defaults tofalse)stopAutoPlayOnTouchoverridespauseAutoPlayOnTouchbehavioronPanDown()andonPanUp()methods to handle stop vs pause correctly.serena/to.gitignoreMotivation
Currently, the
pauseAutoPlayOnTouchoption pauses autoplay during user interaction but automatically resumes it when the user finishes interacting. Some use cases require permanently stopping autoplay once the user starts interacting with the carousel, giving them full control without automatic resumption.Implementation Details
The
stopAutoPlayOnTouchoption takes precedence overpauseAutoPlayOnTouch:stopAutoPlayOnTouch = true: autoplay stops permanently on touch (no resume on pan up)stopAutoPlayOnTouch = falseandpauseAutoPlayOnTouch = true: existing pause/resume behaviorfalse: no autoplay interruption on touchTest Plan
false)