Kata/collections/practice#48
Open
kiran1552 wants to merge 8 commits intoserenity-dojo:kata/collections/startfrom
Open
Kata/collections/practice#48kiran1552 wants to merge 8 commits intoserenity-dojo:kata/collections/startfrom
kiran1552 wants to merge 8 commits intoserenity-dojo:kata/collections/startfrom
Conversation
Kata/collections/start
wakaleo
reviewed
Sep 21, 2016
Contributor
wakaleo
left a comment
wakaleo
left a comment
There was a problem hiding this comment.
A good solution, could be made better (or a better learning experience) using the strategy pattern.
| pets.add(pet); | ||
| confirmStatus=true; | ||
| } | ||
| else |
Contributor
There was a problem hiding this comment.
Always put curly brackets around statements.
| return new ArrayList(pets); | ||
| } | ||
|
|
||
| public BookingResponse checkIn(Pet pet) { |
Contributor
There was a problem hiding this comment.
You could refactor this nicely using the Strategy pattern.
| @@ -1,54 +1,178 @@ | |||
| package serenitylabs.tutorials.vetclinic.collections.katas; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.