WeakReference + CWT EventManager refactoring #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasmann
commented
Sep 15, 2023
vasmann
commented
- changed concept: all global contexts share same EventManager
- EventManager supports WeakReferences + ConditionalWeakTable (CWT)
- EventManager supports AOT generic event handlers which to increase performance. You can still use events without AOT which will produce overhead during event execution + possible boxing for value type events
- EventManager supports ValueType events (consider using AOT through DeclareEvent call to avoid boxing and performance hit)
- EventManager supports event inheritance and filtering. Please note, you can not handle ValueType events with void Handle(object @event) handlers. ValueTypes handlers are invariant
- removed commands concept
- refactored context: renamed methods to more apropriate
- changed concept: all global contexts share same EventManager - EventManager supports WeakReferences + ConditionalWeakTable (CWT) - EventManager supports AOT generic event handlers which to increase performance. You can still use events without AOT which will produce overhead during event execution + possible boxing for value type events - EventManager supports ValueType events (consider using AOT through DeclareEvent call to avoid boxing and performance hit) - EventManager supports event inheritance and filtering. Please note, you can not handle ValueType events with void Handle(object @event) handlers. ValueTypes handlers are invariant - removed commands concept - refactored context: renamed methods to more apropriate
- now you can trigger event like manager.DispatchEvent<Base>(new Derived()) or manager.DispatchEvent<object>(new SomeStruct()) - so if Derived, SomeStruct events were declared they will be called by fast branch. - manager.DispatchEvent<object>(new SomeStruct()) - SomeStruct will be unboxed once and all handlers will receive unboxed value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.