Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Sync for SerialPort trait #233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
impl Sync for SerialPort trait
  • Loading branch information
unlimitedsola committed Jan 23, 2025
commit 6d982c1ddf0735d19887d608ed68b63df7ef25bc
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
@@ -447,7 +447,7 @@ impl SerialPortBuilder {
///
/// This trait is all that's necessary to implement a new serial port driver
/// for a new platform.
pub trait SerialPort: Send + io::Read + io::Write {
pub trait SerialPort: Send + Sync + io::Read + io::Write {
// Port settings getters

/// Returns the name of this port if it exists.
10 changes: 10 additions & 0 deletions src/windows/com.rs
Original file line number Diff line number Diff line change
@@ -32,7 +32,17 @@ pub struct COMPort {
port_name: Option<String>,
}

// The Windows [`HANDLE`] type is considered safe according to the standard library.
// See explanation on [`OwnedHandle`] in stdlib for more information.
//
// [`HANDLE`]: std::os::windows::raw::HANDLE
// [`OwnedHandle`]: std::os::windows::io::OwnedHandle
//
// In the future we might want to consider using `OwnedHandle` instead of `HANDLE` directly.
// At the time of writing, such work is blocked by this crate's MSRV (1.59.0) policy as
// `OwnedHandle` was stabilized in 1.63.0.
unsafe impl Send for COMPort {}
unsafe impl Sync for COMPort {}

impl COMPort {
/// Opens a COM port as a serial device.