Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DTR by default when opening a serial port #239

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

sirhcel
Copy link
Contributor

@sirhcel sirhcel commented Jan 4, 2025

This addresses the issue seen in #29, #204, and on many other occasions by just setting DTR by default when opening a serial port. The new default behavior can be changed through SerialPortBuilder's dtr_on_open and preserve_dtr_on_open.

@sirhcel sirhcel changed the title Set DTR when opening a serial port by default Set DTR by default when opening a serial port Jan 4, 2025
@sirhcel sirhcel force-pushed the dtr-on-open-by-default branch from aacadc4 to 540e764 Compare January 13, 2025 16:57
@sirhcel sirhcel force-pushed the dtr-on-open-by-default branch from 540e764 to 6991d2c Compare January 13, 2025 17:06
@sirhcel sirhcel marked this pull request as ready for review January 13, 2025 18:57
@sirhcel sirhcel requested a review from eldruin January 13, 2025 18:57
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@eldruin eldruin merged commit 88bdbd5 into serialport:main Jan 13, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants