Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration/3.0 #95

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
d164694
Update legacy-coverage for Meteor 3
StorytellerCZ Jul 16, 2024
49319b0
Update for Meteor 3
StorytellerCZ Jul 16, 2024
8133c2f
Merge pull request #92 from StorytellerCZ/patch-2
jankapunkt Aug 1, 2024
1011656
Merge pull request #91 from StorytellerCZ/patch-1
jankapunkt Aug 1, 2024
8e58167
build(deps): npm dependencies updated and package-lock.json added for ci
jankapunkt Aug 1, 2024
8b78bf3
Merge branch 'migration/3.0' of github.com:serut/meteor-coverage into…
jankapunkt Aug 1, 2024
02c8084
fix(deps): use correct eslint 8.x packages
jankapunkt Aug 1, 2024
2994152
fix: fix eslint-reported errors
jankapunkt Aug 1, 2024
b1c7489
migration: migrate packages to meteor 3
jankapunkt Aug 1, 2024
4a7a111
fix: bump istanbul reporters to get html report running
jankapunkt Aug 1, 2024
19461bc
ci: use meteor npm to install dependencies
jankapunkt Aug 1, 2024
452c590
build: move npm-depends to top of package hooks
jankapunkt Aug 1, 2024
15ca791
build(deps): same deps in package.json and npm.depends
jankapunkt Aug 1, 2024
bc1ac15
fix(ci): remove caching from meteor tests
jankapunkt Aug 1, 2024
15abf49
build(deps): install only dev npm dependencies on test
jankapunkt Aug 1, 2024
6864123
deps: harmize npm versions across packages
jankapunkt Aug 1, 2024
ecce228
ci: try to enable legacy peer deps
jankapunkt Aug 1, 2024
3457723
ci: send lcov to codacy/coveralls/codecov
jankapunkt Aug 1, 2024
2751590
try to fix circle ci
serut Aug 1, 2024
c25d3c3
try to fix circle ci
serut Aug 1, 2024
6fba5aa
wip
serut Aug 1, 2024
8300635
wip
serut Aug 1, 2024
9e3e333
wip
serut Aug 1, 2024
6443ba3
wip
serut Aug 1, 2024
4a08010
wip
serut Aug 1, 2024
115a15a
wip
serut Aug 1, 2024
0f62bac
wip
serut Aug 1, 2024
4667fd0
wip
serut Aug 1, 2024
537dda5
wip
serut Aug 1, 2024
c04fde4
clean code
serut Aug 1, 2024
8234a22
fix lint
serut Aug 1, 2024
2a8bfb5
fix coverage
serut Aug 1, 2024
ea8c53c
wip coverage report
serut Aug 1, 2024
4382ce9
wip codecov
serut Aug 1, 2024
69f0add
fix: remove superfluous property strings in res.json responses for be…
jankapunkt Aug 2, 2024
39ce9e4
fix: uncomment replace COVERAE_APP in generic reporter
jankapunkt Aug 2, 2024
d120866
deps: make package 3.0 only since Router is now express
jankapunkt Aug 3, 2024
4d28851
build: make package 3.0 only
jankapunkt Aug 3, 2024
a637094
fix: add explicit package definition to cover self in local package t…
jankapunkt Aug 6, 2024
97020f0
fix: add .babelrc file to instrument package with istanbul
jankapunkt Aug 6, 2024
72e4a65
fix: instrument require hook and better file info
jankapunkt Aug 6, 2024
5107709
fix: prevent errors when attempting to write read-only fileReports fr…
jankapunkt Aug 6, 2024
dc6081e
fix: make linter happy
jankapunkt Aug 6, 2024
e326021
fix: make linter happy
jankapunkt Aug 6, 2024
210568e
fix: add missing BABEL_ENV to test runner scripts
jankapunkt Aug 6, 2024
557d2f1
docs: update readme
jankapunkt Aug 6, 2024
fecf737
build: prepare for new major release
jankapunkt Aug 6, 2024
8bb68bb
fix: prevent express errors when headers have already been sent
jankapunkt Aug 7, 2024
b8562b7
fix: remove outdated istanbul hook to make work with Meteor 3 app-tests
jankapunkt Aug 20, 2024
03b5116
wip deploy
serut Aug 28, 2024
55e5025
wip
serut Aug 28, 2024
f2bd7fc
fix publish
serut Aug 28, 2024
ef15300
remove lock file
serut Aug 28, 2024
8363168
add package lock
serut Aug 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix eslint-reported errors
jankapunkt committed Aug 1, 2024
commit 29941522fc646e7e333f2f7f67d6b8edc06207c9
4 changes: 2 additions & 2 deletions client/methods.e2e.tests.js
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ describe('meteor-coverage', function () {
import: ['coverage']
};
for (let operation in coverage) {
if (coverage.hasOwnProperty(operation)) {
if (Object.hasOwn(coverage, operation)) {
coverage[operation].forEach(function (reportType) {
it(`${operation} [${reportType}]`, function (done) {
testCoverage.call(this, done, operation, reportType); // pass mocha context
@@ -58,7 +58,7 @@ describe('meteor-coverage', function () {
pending: ['clover', 'cobertura', 'lcov', 'text', 'text-lcov']
};
for (let group in reportTypes) {
if (reportTypes.hasOwnProperty(group)) {
if (Object.hasOwn(reportTypes,group)) {
reportTypes[group].forEach(function (reportType) {
it(`export [${reportType}] should fail`, function (done) {
this.timeout(0);
2 changes: 1 addition & 1 deletion client/methods.js
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ Meteor.sendCoverage = function (callback) {
// Send each property alone
for (var property in globalCoverage) {
/* istanbul ignore else */
if (globalCoverage.hasOwnProperty(property)) {
if (Object.hasOwn(globalCoverage, property)) {
Meteor.increaseTotal();

HTTP.call('POST', '/coverage/client', {
4 changes: 3 additions & 1 deletion meteor-legacy-coverage/server/context/log.js
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ const meteor_parameters = {
VERBOSE: Meteor && Meteor.settings && Meteor.settings.coverage && Meteor.settings.coverage.verbose
};

export default Log = {
const Log = {
COVERAGE_VERBOSE: meteor_parameters.VERBOSE || process.env['COVERAGE_VERBOSE'] === '1' || false,
error: function() {
console.error(...arguments);
@@ -29,3 +29,5 @@ export default Log = {
}
}
};

export default Log;
2 changes: 1 addition & 1 deletion meteor-legacy-coverage/server/services/core.js
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@ importCoverage = function (res, options = {}) {
let coverageObj = JSON.parse(fileContent);
for (let property in coverageObj) {
/* istanbul ignore else */
if (coverageObj.hasOwnProperty(property)) {
if (Object.hasOwn(coverageObj, property)) {
Core.mergeCoverageWith(coverageObj[property]);
}
}
4 changes: 2 additions & 2 deletions meteor-legacy-coverage/server/services/source-map.js
Original file line number Diff line number Diff line change
@@ -66,7 +66,7 @@ initialSetup = function () {
// Find the package(s) under test (PUT)
for (let pkg in this.resolved) {
/* istanbul ignore else */
if (this.resolved.hasOwnProperty(pkg)) {
if (Object.hasOwn(this.resolved, pkg)) {
let match = rgx.meteorPUT.exec(pkg);
match && (this.PUT[match[1]] = true);
}
@@ -97,7 +97,7 @@ initialSetup = function () {
};
for (let key in sidePaths) {
/* istanbul ignore else */
if (sidePaths.hasOwnProperty(key)) {
if (Object.hasOwn(sidePaths, key)) {
const programPath = path.join(sidePaths[key], 'program.json');
const program = parseJSON(programPath);
/* istanbul ignore next: file automatically created by Meteor, so really rare to enter here */
4 changes: 3 additions & 1 deletion server/context/log.js
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ const meteor_parameters = {
VERBOSE: Meteor && Meteor.settings && Meteor.settings.coverage && Meteor.settings.coverage.verbose
};

export default Log = {
const Log = {
COVERAGE_VERBOSE: meteor_parameters.VERBOSE || process.env['COVERAGE_VERBOSE'] === '1' || false,
error: function() {
console.error(...arguments);
@@ -29,3 +29,5 @@ export default Log = {
}
}
};

export default Log;
2 changes: 1 addition & 1 deletion server/handlers.js
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ addClientCoverage = function (params, req, res, next) {
var clientCoverage;
for (var property in body) {
/* istanbul ignore else */
if (body.hasOwnProperty(property)) {
if (Object.hasOwn(body, property)) {
clientCoverage = body[property];
}
}
2 changes: 1 addition & 1 deletion server/services/core.js
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@ importCoverage = function (res, options = {}) {
let coverageObj = JSON.parse(fileContent);
for (let property in coverageObj) {
/* istanbul ignore else */
if (coverageObj.hasOwnProperty(property)) {
if (Object.hasOwn(coverageObj, property)) {
Core.mergeCoverageWith(coverageObj[property]);
}
}