ci: fix perms for claude again #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes permissions for the Claude workflow by adding a new allowed tool for installing development requirements. The change expands the permitted bash commands to include pip installation of dev dependencies.
- Adds permission for
pip install -r requirements-dev.txtcommand to the Claude workflow's allowed tools
| @@ -34,4 +34,4 @@ jobs: | |||
| with: | |||
| anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }} | |||
| timeout_minutes: "60" | |||
| allowed_tools: 'Bash(*),Bash(gh *),Bash(pip *),Bash(mypy *),Bash(python *),Bash(mypy servc --check-untyped-defs)' | |||
| allowed_tools: 'Bash(*),Bash(gh *),Bash(pip *),Bash(mypy *),Bash(python *),Bash(mypy servc --check-untyped-defs),Bash(pip install -r requirements-dev.txt)' | |||
There was a problem hiding this comment.
The specific command 'Bash(pip install -r requirements-dev.txt)' is redundant since 'Bash(pip *)' already covers all pip commands including this one. Consider removing the redundant entry to keep the configuration cleaner.
Suggested change
| allowed_tools: 'Bash(*),Bash(gh *),Bash(pip *),Bash(mypy *),Bash(python *),Bash(mypy servc --check-untyped-defs),Bash(pip install -r requirements-dev.txt)' | |
| allowed_tools: 'Bash(*),Bash(gh *),Bash(pip *),Bash(mypy *),Bash(python *),Bash(mypy servc --check-untyped-defs)' |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.