fix: add ability to prefix table location for delta #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to use a custom prefix for Delta table locations by introducing a new delta-prefix configuration option that takes precedence over the existing s3.access-key-id fallback.
- Introduces
delta-prefixconfiguration option for customizing table location prefixes - Maintains backward compatibility by falling back to
s3.access-key-idwhendelta-prefixis not specified
| @@ -37,7 +37,7 @@ def __init__(self, config: Config, table: LakeTable): | |||
| else: | |||
| self._location_prefix = os.path.join( | |||
| str(catalog_properties_raw.get("warehouse")), | |||
| str(catalog_properties_raw.get("s3.access-key-id")), | |||
| str(catalog_properties_raw.get("delta-prefix") or catalog_properties_raw.get("s3.access-key-id")), | |||
There was a problem hiding this comment.
Using an AWS access key ID as a fallback for a table location prefix is questionable from a security perspective, as it exposes sensitive credentials in file paths. Consider using a dedicated configuration option or a more appropriate default value.
Suggested change
| str(catalog_properties_raw.get("delta-prefix") or catalog_properties_raw.get("s3.access-key-id")), | |
| str(catalog_properties_raw.get("delta-prefix") or "default-delta-prefix"), |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.