Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions app/SymfonyRequirements.php
Original file line number Diff line number Diff line change
Expand Up @@ -500,9 +500,9 @@ function_exists('simplexml_import_dom'),
$pcreVersion = defined('PCRE_VERSION') ? (float) PCRE_VERSION : null;

$this->addRequirement(
null !== $pcreVersion && $pcreVersion > 8.0,
sprintf('PCRE extension must be available and at least 8.0 (%s installed)', $pcreVersion ? $pcreVersion : 'not'),
'Upgrade your <strong>PCRE</strong> extension (8.0+).'
null !== $pcreVersion,
'PCRE extension must be available',
'Install the <strong>PCRE</strong> extension (version 8.0+).'
);

/* optional recommendations follow */
Expand Down Expand Up @@ -531,6 +531,14 @@ function_exists('simplexml_import_dom'),
'Your project might not work properly due to the PHP bug #61453 ("Cannot dump definitions which have method calls"). Install PHP 5.4.1 or newer.'
);

if (null !== $pcreVersion) {
$this->addRecommendation(
$pcreVersion >= 8.0,
sprintf('PCRE extension should be at least version 8.0 (%s installed)', $pcreVersion),
'<strong>PCRE 8.0+</strong> is preconfigured in PHP since 5.3.2 but you are using an outdated version of it. Symfony probably works anyway but it is recommended to upgrade your PCRE extension.'
);
}

$this->addRecommendation(
class_exists('DomDocument'),
'PHP-XML module should be installed',
Expand Down
1 change: 1 addition & 0 deletions app/phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<testsuite name="Project Test Suite">
<directory>../src/*/*Bundle/Tests</directory>
<directory>../src/*/Bundle/*Bundle/Tests</directory>
<directory>../vendor/servergrove/kb-bundle/*/*Bundle/Tests</directory>
</testsuite>
</testsuites>

Expand Down
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
"doctrine/doctrine-fixtures-bundle": "dev-master",
"servergrove/translation-editor-bundle": "dev-master",
"jackalope/jackalope-jackrabbit": "dev-master",
"knplabs/knp-markdown-bundle": "dev-master"
"knplabs/knp-markdown-bundle": "dev-master",
"servergrove/kb-bundle": "dev-master"
},
"repositories": [
{
Expand Down
Loading