Skip to content

fix: Endpoint configuration should also accept expressions #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bakjos
Copy link

@bakjos bakjos commented Feb 28, 2025

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

According to the Spec the URI of the Endpoint Configuration can be a template or an expression, when using expressions, the parsing is failing

{
          "title": "EndpointConfiguration",
          "type": "object",
          "unevaluatedProperties": false,
          "properties": {
            "uri": {
              "title": "EndpointUri",
              "description": "The endpoint's URI.",
              "oneOf": [
                {
                  "title": "LiteralEndpointURI",
                  "description": "The literal endpoint's URI.",
                  "$ref": "#/$defs/uriTemplate"
                },
                {
                  "title": "ExpressionEndpointURI",
                  "$ref": "#/$defs/runtimeExpression",
                  "description": "An expression based endpoint's URI."
                }
              ]
            },
            "authentication": {
              "$ref": "#/$defs/referenceableAuthenticationPolicy",
              "title": "EndpointAuthentication",
              "description": "The authentication policy to use."
            }
          },
          "required": [
            "uri"
          ]
        }

Special notes for reviewers:

Additional information (if needed):

@bakjos bakjos force-pushed the bakjos/expression_endpoint branch from 44194d5 to acda9bd Compare February 28, 2025 20:58
Signed-off-by: Gio Gutierrez <bakjos28@yahoo.com.mx>
@bakjos bakjos force-pushed the bakjos/expression_endpoint branch from acda9bd to 870dddb Compare February 28, 2025 21:00
@ricardozanini
Copy link
Member

I'll take a look on this, thanks for the PR!

@ricardozanini
Copy link
Member

@bakjos I've just merged the implementation PR, which I think addresses this issue. Do you mind rebasing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants