Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for http function calls to provide objects #235

Open
wants to merge 7 commits into
base: 2.x
Choose a base branch
from

Conversation

hneale-jc
Copy link

@hneale-jc hneale-jc commented Apr 3, 2025

What this PR does / why we need it:

For the https://github.com/serverlessworkflow/specification/blob/0.9.x/specification.md#using-functions-for-http-service-invocations spec. Function operations for the http type need an map[string]interface{}. This PR instead makes the operator any and adds the http type into the function types set.

Special notes for reviewers:

This maybe a breaking change

Additional information (if needed):

@hneale-jc hneale-jc requested a review from ricardozanini as a code owner April 3, 2025 16:44
@hneale-jc hneale-jc closed this Apr 3, 2025
@hneale-jc hneale-jc deleted the 2.x branch April 3, 2025 16:44
@hneale-jc hneale-jc restored the 2.x branch April 3, 2025 16:44
@ricardozanini
Copy link
Member

Hi @hneale-jc do you have a specific request?

@hneale-jc
Copy link
Author

@ricardozanini no sorry. I didn't mean to open a PR. I was forking to add http support based on the sepc: https://github.com/serverlessworkflow/specification/blob/0.9.x/specification.md#using-functions-for-http-service-invocations as it'll only work with rest/openapi which requires a swagger endpoint. Just needed support for curl. The existing struct only allowed for a string.

@ricardozanini
Copy link
Member

@hneale-jc Oh, I see, so are you using 0.8 spec version? If so, you can propose a patch to 2.x and I will release it.

@hneale-jc hneale-jc reopened this Apr 4, 2025
@hneale-jc hneale-jc changed the title make function support any Allow for http function calls to provide objects Apr 4, 2025
@hneale-jc
Copy link
Author

hneale-jc commented Apr 4, 2025

So this is currently on the 2.x branch. I imagine this will be a breaking change though? As downstream clients will have to cast from any to the string to get their operation. Let me know your thoughts and then I can squash this PR

@ricardozanini
Copy link
Member

@hneale-jc I think we need a new main branch based on 2.x so we keep 2.x on 0.8. I'll create a 2.5.x branch, and you can send your PR there. Do you mind? So I'll release a 2.5.0 based on 0.9, and you can work on this stream. I'll keep the 2.x in 2.4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants