-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for http function calls to provide objects #235
base: 2.x
Are you sure you want to change the base?
Conversation
Hi @hneale-jc do you have a specific request? |
@ricardozanini no sorry. I didn't mean to open a PR. I was forking to add http support based on the sepc: https://github.com/serverlessworkflow/specification/blob/0.9.x/specification.md#using-functions-for-http-service-invocations as it'll only work with rest/openapi which requires a swagger endpoint. Just needed support for curl. The existing struct only allowed for a string. |
@hneale-jc Oh, I see, so are you using 0.8 spec version? If so, you can propose a patch to 2.x and I will release it. |
So this is currently on the 2.x branch. I imagine this will be a breaking change though? As downstream clients will have to cast from any to the string to get their operation. Let me know your thoughts and then I can squash this PR |
@hneale-jc I think we need a new main branch based on 2.x so we keep 2.x on 0.8. I'll create a 2.5.x branch, and you can send your PR there. Do you mind? So I'll release a 2.5.0 based on 0.9, and you can work on this stream. I'll keep the 2.x in 2.4.x. |
What this PR does / why we need it:
For the https://github.com/serverlessworkflow/specification/blob/0.9.x/specification.md#using-functions-for-http-service-invocations spec. Function operations for the http type need an map[string]interface{}. This PR instead makes the operator any and adds the http type into the function types set.
Special notes for reviewers:
This maybe a breaking change
Additional information (if needed):