Skip to content

Another set of fixes fixes for the graph/state machine generation functionality #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Another set of fixes fixes for the graph/state machine generation functionality #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c88a382
detecting the initial state fixed; fixed parallel machine state creat…
oEscal Jul 1, 2025
98fbd74
Merge branch 'main' into bug/wf-initial-graph
oEscal Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions serverlessworkflow/sdk/state_machine_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,11 @@ def definitions(self):

def parallel_state_details(self):
if isinstance(self.state, ParallelState):
if self.state.name not in self.state_machine.states.keys():
self.state_machine.add_states(self.state.name)
if self.is_first_state:
self.state_machine._initial = self.state.name

state_name = self.state.name
branches = self.state.branches
if branches:
Expand Down Expand Up @@ -208,8 +213,8 @@ def data_based_switch_state_details(self): ...
def operation_state_details(self):
if self.state.name not in self.state_machine.states.keys():
self.state_machine.add_states(self.state.name)
if self.is_first_state:
self.state_machine._initial = self.state.name
if self.is_first_state:
self.state_machine._initial = self.state.name

if isinstance(self.state, OperationState):
self.generate_actions_info(
Expand Down Expand Up @@ -264,11 +269,11 @@ def get_subflow_state(
)

# Generate the state machine for the subflow
for index, state in enumerate(sf.states):
for state in sf.states:
StateMachineGenerator(
state=state,
state_machine=new_machine,
is_first_state=index == 0,
is_first_state=sf.start == state.name,
get_actions=self.get_actions,
subflows=self.subflows,
).generate()
Expand Down
4 changes: 2 additions & 2 deletions serverlessworkflow/sdk/state_machine_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ def __init__(
auto_transitions=False,
title=title,
)
for index, state in enumerate(workflow.states):
for state in workflow.states:
StateMachineGenerator(
state=state,
state_machine=self.machine,
is_first_state=index == 0,
is_first_state=workflow.start == state.name,
get_actions=self.get_actions,
subflows=subflows,
).generate()
Expand Down